Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BTCPay Server: Remove deprecated NBXplorer options #1293

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

dennisreimann
Copy link
Contributor

@dennisreimann dennisreimann commented Aug 1, 2024

Copy link

github-actions bot commented Aug 1, 2024

🎉   Linting finished with no errors or warnings   🎉

Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store.

Please review the linting results below and make any necessary changes to your submission.

Linting Results

Severity File Description
ℹ️ btcpay-server/docker-compose.yml Potentially using unsafe user in service "postgres":
The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000.

Legend

Symbol Description
Error: This must be resolved before this PR can be merged.
⚠️ Warning: This is highly encouraged to be resolved, but is not strictly mandatory.
ℹ️ Info: This is just for your information.

@nmfretz
Copy link
Contributor

nmfretz commented Aug 1, 2024

Thanks for this fix @dennisreimann! Really appreciate it. Interestingly, I was not able to reproduce the issue when testing just now.

I have updated the app manifest so that current installs see an available update.

Tested and going live.

@nmfretz nmfretz merged commit 6e62de5 into getumbrel:master Aug 1, 2024
1 check passed
@dennisreimann dennisreimann deleted the patch-1 branch August 1, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants